feat: fix healthy conditions of storaged #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
force-pushed
the
storaged_healthcheck_fix
branch
from
c9845ba
to
a65f648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #116
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #116
Description:
Now the criteria are changed to whether it's listening on
0.0.0.0:9779, as a workaround to avoid confusing fresh users to wait and troubleshoot this before moving forward w/oADD HOSTSP.S. the console
ADD HOSTSfor loop breaks in many use cases as we observed, thus we still need this.How do you solve it?
Do netstat/ss without netstat/ss checking on listening sockets.
Special notes for your reviewer, ex. impact of this fix, design document, etc: